Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIORGS-425: Use Save & close button label stripes-component translation key #637

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

UladzislauKutarkin
Copy link
Contributor

@UladzislauKutarkin UladzislauKutarkin commented Aug 6, 2024

https://folio-org.atlassian.net/browse/UIORGS-425

Here we changed the local translations key for saveAndClose on stripes-components.saveAndClose.

Also, all failed tests was updated

@UladzislauKutarkin UladzislauKutarkin requested review from vashjs and a team August 6, 2024 05:48
Copy link

github-actions bot commented Aug 6, 2024

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit f807f33. ± Comparison against base commit 19daf93.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Aug 6, 2024

Jest Unit Test Statistics

    1 files  ±0    84 suites  ±0   3m 13s ⏱️ -3s
272 tests ±0  272 ✔️ +11  0 💤 ±0  0  - 11 
276 runs  ±0  276 ✔️ +11  0 💤 ±0  0  - 11 

Results for commit f807f33. ± Comparison against base commit 19daf93.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Aug 6, 2024

status={organization.status}
organizationTypes={organization.organizationTypes}
/>
</IntlProvider>,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a comma here?

<QueryClientProvider client={queryClient}>
<OrganizationAccounts
accounts={accounts}
/>,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a comma here?

@artem-blazhko artem-blazhko requested a review from a team August 6, 2024 12:37
@UladzislauKutarkin UladzislauKutarkin merged commit 427c232 into master Aug 12, 2024
6 checks passed
@UladzislauKutarkin UladzislauKutarkin deleted the UIORGS-425 branch August 12, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants